Browse Source

fix: missing await for an async function call (#4035)

Li Kui 7 months ago
parent
commit
e29352d0f1

+ 2 - 2
packages/effects/hooks/src/use-refresh.ts

@@ -6,8 +6,8 @@ export function useRefresh() {
   const router = useRouter();
   const tabbarStore = useTabbarStore();
 
-  function refresh() {
-    tabbarStore.refresh(router);
+  async function refresh() {
+    await tabbarStore.refresh(router);
   }
 
   return {

+ 1 - 1
packages/effects/hooks/src/use-tabs.ts

@@ -44,7 +44,7 @@ export function useTabs() {
   }
 
   async function openTabInNewWindow(tab?: RouteLocationNormalized) {
-    tabbarStore.openTabInNewWindow(tab || route);
+    await tabbarStore.openTabInNewWindow(tab || route);
   }
 
   async function closeTabByKey(key: string) {

+ 5 - 5
packages/effects/hooks/src/use-watermark.ts

@@ -48,18 +48,18 @@ export function useWatermark() {
     };
     watermark.value = new Watermark(cachedOptions.value);
 
-    watermark.value?.create();
+    await watermark.value?.create();
   }
 
   async function updateWatermark(options: Partial<WatermarkOptions>) {
-    if (!watermark.value || !watermark.value?.check()) {
-      await initWatermark(options);
-    } else {
+    if (watermark.value) {
       await nextTick();
-      watermark.value?.changeOptions({
+      await watermark.value?.changeOptions({
         ...cachedOptions.value,
         ...options,
       });
+    } else {
+      await initWatermark(options);
     }
   }
 

+ 1 - 1
packages/stores/src/modules/tabbar.ts

@@ -349,7 +349,7 @@ export const useTabbarStore = defineStore('core-tabbar', {
       }
     },
 
-    async setUpdateTime() {
+    setUpdateTime() {
       this.updateTime = Date.now();
     },
     /**